fix: add underlyingException to FirebaseJsonException when projectId or appId are missing#364
Conversation
…or appId are missing
|
Hi @russellwheatley, I’ve opened a PR for the small improvement we discussed in #354. While testing it locally in my Flutter app, I noticed the However, even with this fix, I couldn't see the exception when building my app. I followed the README and ran |
|
|
||
| if (projectId == null || appId == null) { | ||
| throw FirebaseJsonException(); | ||
| final underlyingException = |
There was a problem hiding this comment.
I was also thinking about adding a separate message for a case when both projectId and appId is missing, but I'm not sure if it's needed - worst case user will first see projectId is missing and then appId is missing
There was a problem hiding this comment.
Yes, I think this works 😄
|
Hi @russellwheatley, any chance you could take a look 🙏? |
|
@Leedwon - regarding local development; did you follow the local development instructions? https://github.com/invertase/flutterfire_cli#local-development-setup Important to note that you need to delete the snapshot in I'm going to be some devving on FFCLI today so I might write that script later. |
|
|
||
| if (projectId == null || appId == null) { | ||
| throw FirebaseJsonException(); | ||
| final underlyingException = |
There was a problem hiding this comment.
Yes, I think this works 😄
Description
This is a follow up to #354. It improves the error message for misconfigured
firebase.jsonfile.feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore